One Discord invite, and a website that exists - #466
Merged
Conversation
There were two invites in the tree pointing at different servers. The README, CONTRIBUTING and the issue-template chooser used one; the About panel and the "report a failure" link inside the app used another. So where someone landed depended on which door they came through, and neither was the server in use. All five now point at discord.gg/YhCKsjhcwB. The README also still described the website as coming soon, next to a working link to it. The site is deployed, so the note is gone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #465
Two invites were live in the tree, pointing at different servers, and neither was the one in use. Where someone landed depended on which door they came through.
README.md(badge + links table)2MVsWqaPReYhCKsjhcwBCONTRIBUTING.md2MVsWqaPReYhCKsjhcwB.github/ISSUE_TEMPLATE/config.yml2MVsWqaPReYhCKsjhcwBstatic/index.html(About panel)JGk7FdZb9NYhCKsjhcwBstatic/js/notifications.js(report a failure)JGk7FdZb9NYhCKsjhcwBThe README also still carried
*(coming soon)*next to a working link to stemdeck.app. The site is deployed, so that is gone.Seven lines, no logic.
node --checkpasses onnotifications.jsandconfig.ymlstill parses as YAML, which matters because a malformed chooser file drops the "ask a question" entry silently rather than failing.Worth knowing: the two
static/changes only reach users in a release. The three docs changes take effect the moment this merges.